From: Hoegeun Kwon Date: Mon, 7 Jan 2019 01:35:43 +0000 (+0900) Subject: fimc-is: Fix bool-operation build warning with arm64 X-Git-Tag: submit/tizen/20190117.082548~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ffa0d6bdf60f67ca5635c63e8c08135b01e8cea7;p=platform%2Fkernel%2Flinux-exynos.git fimc-is: Fix bool-operation build warning with arm64 This patch fixes following build warning caused boolean expression: drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c: In function ‘flite_hw_enable_bns’: drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c:187:45: warning: ‘~’ on a boolean expression [-Wbool-operation] #define FLITE_REG_BINNINGON_CLKGATE_ON(x) (~(x) << 1) drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c:241:9: note: in expansion of macro ‘FLITE_REG_BINNINGON_CLKGATE_ON’ cfg |= FLITE_REG_BINNINGON_CLKGATE_ON(enable); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c:187:45: note: did you mean to use logical not? #define FLITE_REG_BINNINGON_CLKGATE_ON(x) (~(x) << 1) drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c:241:9: note: in expansion of macro ‘FLITE_REG_BINNINGON_CLKGATE_ON’ cfg |= FLITE_REG_BINNINGON_CLKGATE_ON(enable); Change-Id: I9b16f36de1bb6d56d2eced55ea97697179dca2b7 Signed-off-by: Hoegeun Kwon --- diff --git a/drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c b/drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c index ca45acb8087d..d4a1c94a0b36 100644 --- a/drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c +++ b/drivers/media/platform/exynos/fimc-is/fimc-is-device-flite.c @@ -238,7 +238,7 @@ static void flite_hw_enable_bns(void __iomem *base_reg, bool enable) /* enable */ cfg = readl(base_reg + FLITE_REG_BINNINGON); - cfg |= FLITE_REG_BINNINGON_CLKGATE_ON(enable); + cfg |= FLITE_REG_BINNINGON_CLKGATE_ON((enable ? 1U : 0U)); cfg |= FLITE_REG_BINNINGON_EN(enable); writel(cfg, base_reg + FLITE_REG_BINNINGON); }