From: Ryan Lortie <desrt@desrt.ca>
Date: Thu, 13 Feb 2014 21:34:29 +0000 (-0500)
Subject: gsocket: use cancellable child source
X-Git-Tag: 2.39.91~20
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ff96f88e172d504b5aef2a852880e21341809e1f;p=platform%2Fupstream%2Fglib.git

gsocket: use cancellable child source

Now that GCancellable's GSource is based on _set_ready_time() instead of
an fd, we should use it as a child source, instead of forcing the
creation of the fd and adding it as a poll.

https://bugzilla.gnome.org/show_bug.cgi?id=724707
---

diff --git a/gio/gsocket.c b/gio/gsocket.c
index 71493bb..79aab0e 100644
--- a/gio/gsocket.c
+++ b/gio/gsocket.c
@@ -3207,8 +3207,6 @@ typedef struct {
   GPollFD       pollfd;
   GSocket      *socket;
   GIOCondition  condition;
-  GCancellable *cancellable;
-  GPollFD       cancel_pollfd;
   gint64        timeout_time;
 } GSocketSource;
 
@@ -3218,9 +3216,6 @@ socket_source_prepare (GSource *source,
 {
   GSocketSource *socket_source = (GSocketSource *)source;
 
-  if (g_cancellable_is_cancelled (socket_source->cancellable))
-    return TRUE;
-
   if (socket_source->timeout_time)
     {
       gint64 now;
@@ -3299,12 +3294,6 @@ socket_source_finalize (GSource *source)
 #endif
 
   g_object_unref (socket);
-
-  if (socket_source->cancellable)
-    {
-      g_cancellable_release_fd (socket_source->cancellable);
-      g_object_unref (socket_source->cancellable);
-    }
 }
 
 static gboolean
@@ -3371,11 +3360,14 @@ socket_source_new (GSocket      *socket,
   socket_source->socket = g_object_ref (socket);
   socket_source->condition = condition;
 
-  if (g_cancellable_make_pollfd (cancellable,
-                                 &socket_source->cancel_pollfd))
+  if (cancellable)
     {
-      socket_source->cancellable = g_object_ref (cancellable);
-      g_source_add_poll (source, &socket_source->cancel_pollfd);
+      GSource *cancellable_source;
+
+      cancellable_source = g_cancellable_source_new (cancellable);
+      g_source_add_child_source (source, cancellable_source);
+      g_source_set_dummy_callback (cancellable_source);
+      g_source_unref (cancellable_source);
     }
 
 #ifdef G_OS_WIN32