From: Johan Hovold <jhovold@gmail.com>
Date: Tue, 13 Aug 2013 11:27:35 +0000 (+0200)
Subject: USB: keyspan: fix null-deref at disconnect and release
X-Git-Tag: upstream/snapshot3+hdmi~4548^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ff8a43c10f1440f07a5faca0c1556921259f7f76;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

USB: keyspan: fix null-deref at disconnect and release

Make sure to fail properly if the device is not accepted during attach
in order to avoid null-pointer derefs (of missing interface private
data) at disconnect or release.

Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index 5a97972..58c17fd 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -2303,7 +2303,7 @@ static int keyspan_startup(struct usb_serial *serial)
 	if (d_details == NULL) {
 		dev_err(&serial->dev->dev, "%s - unknown product id %x\n",
 		    __func__, le16_to_cpu(serial->dev->descriptor.idProduct));
-		return 1;
+		return -ENODEV;
 	}
 
 	/* Setup private data for serial driver */