From: Chuansheng Liu Date: Fri, 21 Dec 2012 10:17:12 +0000 (+0800) Subject: ASoC: core: giving WARN when device starting from non-off bias with idle_bias_off X-Git-Tag: upstream/snapshot3+hdmi~5621^2~16^2~27^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ff541f4b2a7546ffa8edf123f4b3b49bb24574e2;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git ASoC: core: giving WARN when device starting from non-off bias with idle_bias_off Just found some cases that some codec drivers set the bias to _STANDBY and set idle_bias_off to 1 during probing. It will cause unpaired runtime_get_sync/put() issue. Also as Mark suggested, there is no reason to start from _STANDBY bias with idle_bias_off == 1. So here giving one warning when detected (dapm.idle_bias_off == 1) and (dapm.bias_level != SND_SOC_BIAS_OFF) just after driver->probe(). Signed-off-by: liu chuansheng Signed-off-by: Mark Brown --- diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 91d592f..e0e8ce0 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1107,6 +1107,10 @@ static int soc_probe_codec(struct snd_soc_card *card, "ASoC: failed to probe CODEC %d\n", ret); goto err_probe; } + WARN(codec->dapm.idle_bias_off && + codec->dapm.bias_level != SND_SOC_BIAS_OFF, + "codec %s can not start from non-off bias" + " with idle_bias_off==1\n", codec->name); } /* If the driver didn't set I/O up try regmap */