From: Tapani Pälli <tapani.palli@intel.com>
Date: Thu, 10 Aug 2023 05:07:29 +0000 (+0300)
Subject: mesa: remove GL_UNSIGNED_BYTE as supported for snorm reads
X-Git-Tag: upstream/23.3.3~2620
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ff17766fbb4ac1a42416e70bc1af3ac393469b5b;p=platform%2Fupstream%2Fmesa.git

mesa: remove GL_UNSIGNED_BYTE as supported for snorm reads

UNSIGNED_BYTE should not be allowed for reading snorm color buffers.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9718
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24600>
---

diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
index 99788846..d60159c 100644
--- a/src/mesa/main/readpix.c
+++ b/src/mesa/main/readpix.c
@@ -968,15 +968,6 @@ read_pixels_es3_error_check(struct gl_context *ctx, GLenum format, GLenum type,
                return GL_NO_ERROR;
          }
       }
-      if (type == GL_UNSIGNED_BYTE) {
-         switch (internalFormat) {
-         case GL_R8_SNORM:
-         case GL_RG8_SNORM:
-         case GL_RGBA8_SNORM:
-            if (_mesa_has_EXT_render_snorm(ctx))
-               return GL_NO_ERROR;
-         }
-      }
       break;
    case GL_BGRA:
       /* GL_EXT_read_format_bgra */