From: Arend van Spriel <arend@broadcom.com>
Date: Mon, 8 Aug 2011 13:58:06 +0000 (+0200)
Subject: staging: brcm80211: use native error code in brcmf_c_pattern_atoh()
X-Git-Tag: upstream/snapshot3+hdmi~8929^2^2~864^2~362
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fee32378cad26dbe3f16009ba8ce43f483d10a19;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

staging: brcm80211: use native error code in brcmf_c_pattern_atoh()

The function brcmf_c_pattern_atoh() returned meaningless -1 value.
These have been replaced by linux error code -EINVAL.

Signed-off-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_common.c b/drivers/staging/brcm80211/brcmfmac/dhd_common.c
index 1e757b7..4412893 100644
--- a/drivers/staging/brcm80211/brcmfmac/dhd_common.c
+++ b/drivers/staging/brcm80211/brcmfmac/dhd_common.c
@@ -841,12 +841,12 @@ static int brcmf_c_pattern_atoh(char *src, char *dst)
 	int i;
 	if (strncmp(src, "0x", 2) != 0 && strncmp(src, "0X", 2) != 0) {
 		BRCMF_ERROR(("Mask invalid format. Needs to start with 0x\n"));
-		return -1;
+		return -EINVAL;
 	}
 	src = src + 2;		/* Skip past 0x */
 	if (strlen(src) % 2 != 0) {
 		BRCMF_ERROR(("Mask invalid format. Length must be even.\n"));
-		return -1;
+		return -EINVAL;
 	}
 	for (i = 0; *src != '\0'; i++) {
 		char num[3];