From: Shivani Bhardwaj Date: Thu, 15 Oct 2015 20:06:31 +0000 (+0530) Subject: Staging: lustre: lproc_osc: Change the variable to be checked X-Git-Tag: v4.4-rc1~125^2~585 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fea6fc647b589e5954330f1f0497b6de59b7fe01;p=platform%2Fkernel%2Flinux-exynos.git Staging: lustre: lproc_osc: Change the variable to be checked The variable rc is supposed to hold the value returned by function kstrtoul which can either be 0, -EINVAL (-22) or -ERANGE (-34). Therefore, the check must be performed on rc instead of val for error values. Also, rc can never be greater than 0. Signed-off-by: Shivani Bhardwaj Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c index 053d508..cdc7f88 100644 --- a/drivers/staging/lustre/lustre/osc/lproc_osc.c +++ b/drivers/staging/lustre/lustre/osc/lproc_osc.c @@ -61,9 +61,7 @@ static ssize_t active_store(struct kobject *kobj, struct attribute *attr, unsigned long val; rc = kstrtoul(buffer, 10, &val); - if (rc) - return rc; - if (val < 0 || val > 1) + if (rc < 0) return -ERANGE; /* opposite senses */