From: Quentin Monnet Date: Sat, 20 Oct 2018 22:01:50 +0000 (+0100) Subject: tools: bpftool: fix completion for "bpftool map update" X-Git-Tag: v5.4-rc1~2403^2~32^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fe8ecccc10b3adc071de05ca7af728ca1a4ac9aa;p=platform%2Fkernel%2Flinux-rpi.git tools: bpftool: fix completion for "bpftool map update" When trying to complete "bpftool map update" commands, the call to printf would print an error message that would show on the command line if no map is found to complete the command line. Fix it by making sure we have map ids to complete the line with, before we try to print something. Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicinski Signed-off-by: Daniel Borkmann --- diff --git a/tools/bpf/bpftool/bash-completion/bpftool b/tools/bpf/bpftool/bash-completion/bpftool index c56545e..3f78e64 100644 --- a/tools/bpf/bpftool/bash-completion/bpftool +++ b/tools/bpf/bpftool/bash-completion/bpftool @@ -143,7 +143,7 @@ _bpftool_map_update_map_type() local type type=$(bpftool -jp map show $keyword $ref | \ command sed -n 's/.*"type": "\(.*\)",$/\1/p') - printf $type + [[ -n $type ]] && printf $type } _bpftool_map_update_get_id()