From: brianosman <brianosman@google.com>
Date: Mon, 26 Sep 2016 17:43:21 +0000 (-0700)
Subject: Tag checkerboard bitmaps as sRGB
X-Git-Tag: submit/tizen/20180928.044319~106^2~197
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fe843cea499ba163d53281425af210b1887d28e7;p=platform%2Fupstream%2FlibSkiaSharp.git

Tag checkerboard bitmaps as sRGB

Significantly reduces the diff between legacy and sRGB/F16 on about 25
GMs. This is just the biggest piece of low-hanging fruit. Many GMs create
N32 raster surfaces to procedurally generate source textures, and I'd like
to fix all of them. It's much easier to reason about the GMs (is sRGB
doing the right thing) when everything is tagged like this - the only
expected differences are due to filtering and blending.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003

Review-Url: https://codereview.chromium.org/2368933003
---

diff --git a/tools/sk_tool_utils.cpp b/tools/sk_tool_utils.cpp
index 0978058238..72d1af5083 100644
--- a/tools/sk_tool_utils.cpp
+++ b/tools/sk_tool_utils.cpp
@@ -200,7 +200,7 @@ void write_pixels(SkCanvas* canvas, const SkBitmap& bitmap, int x, int y,
 
 sk_sp<SkShader> create_checkerboard_shader(SkColor c1, SkColor c2, int size) {
     SkBitmap bm;
-    bm.allocN32Pixels(2 * size, 2 * size);
+    bm.allocPixels(SkImageInfo::MakeS32(2 * size, 2 * size, kPremul_SkAlphaType));
     bm.eraseColor(c1);
     bm.eraseArea(SkIRect::MakeLTRB(0, 0, size, size), c2);
     bm.eraseArea(SkIRect::MakeLTRB(size, size, 2 * size, 2 * size), c2);
@@ -210,7 +210,7 @@ sk_sp<SkShader> create_checkerboard_shader(SkColor c1, SkColor c2, int size) {
 
 SkBitmap create_checkerboard_bitmap(int w, int h, SkColor c1, SkColor c2, int checkSize) {
     SkBitmap bitmap;
-    bitmap.allocN32Pixels(w, h);
+    bitmap.allocPixels(SkImageInfo::MakeS32(w, h, kPremul_SkAlphaType));
     SkCanvas canvas(bitmap);
 
     sk_tool_utils::draw_checkerboard(&canvas, c1, c2, checkSize);