From: Jan Schmidt <thaytan@mad.scientist.com>
Date: Thu, 20 Nov 2008 14:30:40 +0000 (+0000)
Subject: gst/matroska/matroska-mux.c: Fix NULL pointer dereference of an unset codec_id in... 
X-Git-Tag: 1.19.3~509^2~10894
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fe7d1d7ae0ffabbd19ace6900e1dd9b83e22e95c;p=platform%2Fupstream%2Fgstreamer.git

gst/matroska/matroska-mux.c: Fix NULL pointer dereference of an unset codec_id in the recently added Dirac paths

Original commit message from CVS:
* gst/matroska/matroska-mux.c:
Fix NULL pointer dereference of an unset codec_id in the recently
added Dirac paths
---

diff --git a/ChangeLog b/ChangeLog
index 0c013a6..8a894bd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2008-11-20  Jan Schmidt  <jan.schmidt@sun.com>
 
+	* gst/matroska/matroska-mux.c:
+	Fix NULL pointer dereference of an unset codec_id in the recently 
+	added Dirac paths
+
+2008-11-20  Jan Schmidt  <jan.schmidt@sun.com>
+
 	* tests/check/Makefile.am:
 	Just keep disabling elements that hang the states test until it
 	works.
diff --git a/gst/matroska/matroska-mux.c b/gst/matroska/matroska-mux.c
index 866157f..97c4333 100644
--- a/gst/matroska/matroska-mux.c
+++ b/gst/matroska/matroska-mux.c
@@ -2099,7 +2099,8 @@ gst_matroska_mux_write_data (GstMatroskaMux * mux, GstMatroskaPad * collect_pad)
   }
 
   /* for dirac we have to queue up everything up to a picture unit */
-  if (strcmp (collect_pad->track->codec_id,
+  if (collect_pad->track->codec_id != NULL &&
+      strcmp (collect_pad->track->codec_id,
           GST_MATROSKA_CODEC_ID_VIDEO_DIRAC) == 0) {
     buf = gst_matroska_mux_handle_dirac_packet (mux, collect_pad, buf);
     if (!buf)