From: Dae Kim Date: Fri, 8 Apr 2016 10:08:05 +0000 (+0100) Subject: dEQP-VK.memory.pipeline_barrier.*: memory leak: delete render pass commands. X-Git-Tag: upstream/0.1.0~671^2~61^2~2^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fe798e33903f2a96975c6150dfc70b1ea7a72847;p=platform%2Fupstream%2FVK-GL-CTS.git dEQP-VK.memory.pipeline_barrier.*: memory leak: delete render pass commands. SubmitRenderPass was taking ownership of the render pass commands but was not freeing them in the destructor. --- diff --git a/external/vulkancts/modules/vulkan/memory/vktMemoryPipelineBarrierTests.cpp b/external/vulkancts/modules/vulkan/memory/vktMemoryPipelineBarrierTests.cpp index 7108c43..5923fe1 100644 --- a/external/vulkancts/modules/vulkan/memory/vktMemoryPipelineBarrierTests.cpp +++ b/external/vulkancts/modules/vulkan/memory/vktMemoryPipelineBarrierTests.cpp @@ -4265,7 +4265,7 @@ class SubmitRenderPass : public CmdCommand { public: SubmitRenderPass (const vector& commands); - ~SubmitRenderPass (void) {} + ~SubmitRenderPass (void); const char* getName (void) const { return "SubmitRenderPass"; } void logPrepare (TestLog&, size_t) const; @@ -4295,6 +4295,12 @@ SubmitRenderPass::SubmitRenderPass (const vector& commands) { } +SubmitRenderPass::~SubmitRenderPass() +{ + for (size_t cmdNdx = 0; cmdNdx < m_commands.size(); cmdNdx++) + delete m_commands[cmdNdx]; +} + void SubmitRenderPass::logPrepare (TestLog& log, size_t commandIndex) const { const string sectionName (de::toString(commandIndex) + ":" + getName());