From: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date: Mon, 7 Apr 2014 16:33:34 +0000 (+0100)
Subject: queue2: warn if we can't remove our temporary file
X-Git-Tag: 1.3.1~57
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fe7925373de46cfde4f5eda4b111a167a4212c74;p=platform%2Fupstream%2Fgstreamer.git

queue2: warn if we can't remove our temporary file

It's not fatal though, so do not error out.

Coverity 1037121
---

diff --git a/plugins/elements/gstqueue2.c b/plugins/elements/gstqueue2.c
index 5389681..4feaf97 100644
--- a/plugins/elements/gstqueue2.c
+++ b/plugins/elements/gstqueue2.c
@@ -1523,8 +1523,12 @@ gst_queue2_close_temp_location_file (GstQueue2 * queue)
   fflush (queue->temp_file);
   fclose (queue->temp_file);
 
-  if (queue->temp_remove)
-    remove (queue->temp_location);
+  if (queue->temp_remove) {
+    if (remove (queue->temp_location) < 0) {
+      GST_WARNING_OBJECT (queue, "Failed to remove temporary file %s: %s",
+          queue->temp_location, strerror (errno));
+    }
+  }
 
   queue->temp_file = NULL;
   clean_ranges (queue);