From: Wim Taymans <wim.taymans@collabora.co.uk>
Date: Wed, 28 Nov 2012 11:39:37 +0000 (+0100)
Subject: media: unref pipeline in finalize to avoid leaking it
X-Git-Tag: 1.19.3~495^2~1223
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fe71114a7dc6544491d522cc4793e11b534d43ec;p=platform%2Fupstream%2Fgstreamer.git

media: unref pipeline in finalize to avoid leaking it
---

diff --git a/gst/rtsp-server/rtsp-media.c b/gst/rtsp-server/rtsp-media.c
index e5abb0e..3fee991 100644
--- a/gst/rtsp-server/rtsp-media.c
+++ b/gst/rtsp-server/rtsp-media.c
@@ -171,6 +171,8 @@ gst_rtsp_media_finalize (GObject * obj)
 
   g_list_free_full (media->dynamic, gst_object_unref);
 
+  if (media->pipeline)
+    gst_object_unref (media->pipeline);
   if (media->auth)
     g_object_unref (media->auth);
   if (media->pool)
@@ -666,7 +668,6 @@ gst_rtsp_media_collect_streams (GstRTSPMedia * media)
       /* create the stream */
       gst_rtsp_media_create_stream (media, elem, pad);
       gst_object_unref (pad);
-
       gst_object_unref (elem);
 
       have_elem = TRUE;
diff --git a/gst/rtsp-server/rtsp-media.h b/gst/rtsp-server/rtsp-media.h
index b848a10..64cda5e 100644
--- a/gst/rtsp-server/rtsp-media.h
+++ b/gst/rtsp-server/rtsp-media.h
@@ -76,7 +76,7 @@ typedef enum {
  * @buffer_size: The UDP buffer size
  * @auth: the authentication service in use
  * @multicast_group: the multicast group to use
- * @element: the data providing element
+ * @element: the data providing element, owned by @pipeline
  * @streams: the different #GstRTSPStream provided by @element
  * @dynamic: list of dynamic elements managed by @element
  * @status: the status of the media pipeline