From: Gustavo A. R. Silva <gustavo@embeddedor.com>
Date: Wed, 9 Aug 2017 16:00:54 +0000 (-0500)
Subject: platform/x86: intel_mid_powerbtn: fix error return code in mid_pb_probe()
X-Git-Tag: v4.14-rc1~85^2~12
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fe4e8d0910540db28e457ce792ae2b29ee66ab8a;p=platform%2Fkernel%2Flinux-exynos.git

platform/x86: intel_mid_powerbtn: fix error return code in mid_pb_probe()

platform_get_irq() returns an error code, but the intel_mid_powerbtn
driver ignores it and always returns -EINVAL. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Print error message and propagate the return value of platform_get_irq
on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

diff --git a/drivers/platform/x86/intel_mid_powerbtn.c b/drivers/platform/x86/intel_mid_powerbtn.c
index 871cfa6..854a16d 100644
--- a/drivers/platform/x86/intel_mid_powerbtn.c
+++ b/drivers/platform/x86/intel_mid_powerbtn.c
@@ -142,8 +142,10 @@ static int mid_pb_probe(struct platform_device *pdev)
 	if (!id)
 		return -ENODEV;
 
-	if (irq < 0)
-		return -EINVAL;
+	if (irq < 0) {
+		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
+		return irq;
+	}
 
 	input = devm_input_allocate_device(&pdev->dev);
 	if (!input)