From: Thibault Saunier <thibault.saunier@osg.samsung.com>
Date: Fri, 24 Feb 2017 18:44:36 +0000 (-0300)
Subject: ges: Keep internal symbols internal
X-Git-Tag: 1.19.3~493^2~845
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fe2efd161dbacfc442759b294150d719c2a3fe18;p=platform%2Fupstream%2Fgstreamer.git

ges: Keep internal symbols internal

The following implementation details where exposed as public symbols:
  - _ges_container_get_priority_offset
  - _ges_container_set_height
  - _ges_container_set_priority_offset
  - _ges_uri_asset_cleanup

but it was not correct and that should never have been used outside
GES.

Moving those declarations to the internal header and marking as
internal.
---

diff --git a/ges/ges-container.h b/ges/ges-container.h
index 5395aea..67ff0a9 100644
--- a/ges/ges-container.h
+++ b/ges/ges-container.h
@@ -144,20 +144,11 @@ gboolean ges_container_remove     (GESContainer *container, GESTimelineElement *
 GList * ges_container_ungroup     (GESContainer * container, gboolean recursive);
 GESContainer *ges_container_group (GList *containers);
 
-/* To be used by subclasses only */
-void _ges_container_set_height                (GESContainer * container,
-                                               guint32 height);
-gboolean ges_container_edit                   (GESContainer * container,
-                                               GList * layers, gint new_layer_priority,
-                                               GESEditMode mode,
-                                               GESEdge edge,
-                                               guint64 position);
-gint  _ges_container_get_priority_offset      (GESContainer * container,
-                                               GESTimelineElement *elem);
-void _ges_container_set_priority_offset       (GESContainer * container,
-                                               GESTimelineElement *elem,
-                                               gint32 priority_offset);
-
+gboolean ges_container_edit       (GESContainer * container,
+                                   GList * layers, gint new_layer_priority,
+                                   GESEditMode mode,
+                                   GESEdge edge,
+                                   guint64 position);
 
 G_END_DECLS
 #endif /* _GES_CONTAINER */
diff --git a/ges/ges-internal.h b/ges/ges-internal.h
index 78e0fe8..508b099 100644
--- a/ges/ges-internal.h
+++ b/ges/ges-internal.h
@@ -157,6 +157,8 @@ ges_effect_assect_id_get_type_and_bindesc (const char    *id,
                                            GESTrackType  *track_type,
                                            GError       **error);
 
+G_GNUC_INTERNAL void _ges_uri_asset_cleanup (void);
+
 /* GESExtractable internall methods
  *
  * FIXME Check if that should be public later
@@ -320,6 +322,14 @@ ges_base_xml_formatter_set_timeline_properties(GESBaseXmlFormatter * self,
  ****************************************************/
 G_GNUC_INTERNAL void _ges_container_sort_children         (GESContainer *container);
 G_GNUC_INTERNAL void _ges_container_sort_children_by_end  (GESContainer *container);
+G_GNUC_INTERNAL void _ges_container_set_height            (GESContainer * container,
+                                                           guint32 height);
+G_GNUC_INTERNAL gint  _ges_container_get_priority_offset  (GESContainer * container,
+                                                           GESTimelineElement *elem);
+G_GNUC_INTERNAL void _ges_container_set_priority_offset   (GESContainer * container,
+                                                           GESTimelineElement *elem,
+                                                           gint32 priority_offset);
+
 
 /****************************************************
  *                  GESClip                         *
diff --git a/ges/ges-uri-asset.h b/ges/ges-uri-asset.h
index b1a0ca4..8fe053f 100644
--- a/ges/ges-uri-asset.h
+++ b/ges/ges-uri-asset.h
@@ -116,7 +116,5 @@ GstDiscovererStreamInfo * ges_uri_source_asset_get_stream_info     (GESUriSource
 const gchar * ges_uri_source_asset_get_stream_uri                  (GESUriSourceAsset *asset);
 const GESUriClipAsset *ges_uri_source_asset_get_filesource_asset   (GESUriSourceAsset *asset);
 
-void _ges_uri_asset_cleanup (void);
-
 G_END_DECLS
 #endif /* _GES_URI_CLIP_ASSET */
diff --git a/win32/common/libges.def b/win32/common/libges.def
index 3816091..55302a2 100644
--- a/win32/common/libges.def
+++ b/win32/common/libges.def
@@ -1,9 +1,5 @@
 EXPORTS
-	_ges_container_get_priority_offset
-	_ges_container_set_height
-	_ges_container_set_priority_offset
 	_ges_debug DATA
-	_ges_uri_asset_cleanup
 	ges_add_missing_uri_relocation_uri
 	ges_asset_cache_lookup
 	ges_asset_extract