From: Sebastian Dröge Date: Sun, 11 Dec 2016 11:27:27 +0000 (+0200) Subject: scaletempo: Ensure to reinit buffers whenever they were not allocated yet X-Git-Tag: 1.12.2~273 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fe2ae2c0f7fccb6e9cb483a188a15e9d4ea2909e;p=platform%2Fupstream%2Fgst-plugins-good.git scaletempo: Ensure to reinit buffers whenever they were not allocated yet That is, whenever we go through start/stop we have to ensure that on the next opportunity the buffers are reallocated again. Otherwise the buffers might be NULL because the element was reused with the same configuration as before (i.e. set_caps() wouldn't have reinited the buffers). https://bugzilla.gnome.org/show_bug.cgi?id=775898 --- diff --git a/gst/audiofx/gstscaletempo.c b/gst/audiofx/gstscaletempo.c index 2f14d6b..04f08e7 100644 --- a/gst/audiofx/gstscaletempo.c +++ b/gst/audiofx/gstscaletempo.c @@ -699,6 +699,7 @@ gst_scaletempo_start (GstBaseTransform * trans) gst_segment_init (&scaletempo->in_segment, GST_FORMAT_UNDEFINED); gst_segment_init (&scaletempo->out_segment, GST_FORMAT_UNDEFINED); + scaletempo->reinit_buffers = TRUE; return TRUE; } @@ -718,6 +719,7 @@ gst_scaletempo_stop (GstBaseTransform * trans) scaletempo->buf_pre_corr = NULL; g_free (scaletempo->table_window); scaletempo->table_window = NULL; + scaletempo->reinit_buffers = TRUE; return TRUE; }