From: Linus Walleij Date: Tue, 22 Dec 2015 14:47:31 +0000 (+0100) Subject: mfd: dm355evm_mps: Be sure to clamp return value X-Git-Tag: v4.5~336^2~26 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fe0b486729e1ae837cf0afd1005d3c10a78f9807;p=platform%2Fkernel%2Flinux-amlogic.git mfd: dm355evm_mps: Be sure to clamp return value As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Signed-off-by: Linus Walleij Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c index 4c826f7..bf3e0b2 100644 --- a/drivers/mfd/dm355evm_msp.c +++ b/drivers/mfd/dm355evm_msp.c @@ -147,7 +147,7 @@ static int msp_gpio_get(struct gpio_chip *chip, unsigned offset) return status; if (reg == DM355EVM_MSP_LED) msp_led_cache = status; - return status & MSP_GPIO_MASK(offset); + return !!(status & MSP_GPIO_MASK(offset)); } static int msp_gpio_out(struct gpio_chip *chip, unsigned offset, int value)