From: Corentin LABBE <clabbe.montjoie@gmail.com>
Date: Fri, 26 Aug 2016 11:11:33 +0000 (+0200)
Subject: hwrng: amd - release_region must be called after hwrng_unregister
X-Git-Tag: v5.15~12686^2~69
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fdec60d683568c8e79457c106fa6642ca7ae95f3;p=platform%2Fkernel%2Flinux-starfive.git

hwrng: amd - release_region must be called after hwrng_unregister

The driver release the memory region before being sure that nobody use
it.

This patch made hwrng_unregister ran before any release was done.

Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char/hw_random/amd-rng.c
index de82fe3..383e1974 100644
--- a/drivers/char/hw_random/amd-rng.c
+++ b/drivers/char/hw_random/amd-rng.c
@@ -151,8 +151,9 @@ static void __exit mod_exit(void)
 {
 	u32 pmbase = (unsigned long)amd_rng.priv;
 
-	release_region(pmbase + 0xF0, 8);
 	hwrng_unregister(&amd_rng);
+
+	release_region(pmbase + 0xF0, 8);
 }
 
 module_init(mod_init);