From: Dan Carpenter Date: Thu, 28 Feb 2013 04:43:12 +0000 (+0300) Subject: usb: gadget: f_uac1: silence an info leak warning X-Git-Tag: v3.9-rc3~17^2~7^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fddedd8334d8b4ac6374894d5eed237d18ce1afb;p=platform%2Fkernel%2Flinux-stable.git usb: gadget: f_uac1: silence an info leak warning Smatch complains that "len" could be larger than the sizeof(value) so we could be copying garbage here. I have changed this to match how things are done in composite_setup(). The call tree looks like: composite_setup() --> f_audio_setup() --> audio_get_intf_req() composite_setup() expects the return value to be set to sizeof(value). Signed-off-by: Dan Carpenter Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/gadget/f_uac1.c b/drivers/usb/gadget/f_uac1.c index f570e66..fa8ea4e 100644 --- a/drivers/usb/gadget/f_uac1.c +++ b/drivers/usb/gadget/f_uac1.c @@ -418,6 +418,7 @@ static int audio_get_intf_req(struct usb_function *f, req->context = audio; req->complete = f_audio_complete; + len = min_t(size_t, sizeof(value), len); memcpy(req->buf, &value, len); return len;