From: Sebastian Dröge <sebastian@centricular.com>
Date: Mon, 22 Jun 2020 09:32:03 +0000 (+0300)
Subject: Don't call gst_ghost_pad_construct() anymore
X-Git-Tag: 1.19.3~511^2~555
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fddd7df2d3be65468f04db54aa1a2e707949c4da;p=platform%2Fupstream%2Fgstreamer.git

Don't call gst_ghost_pad_construct() anymore

It's deprecated, unneeded and doesn't do anything anymore.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/717>
---

diff --git a/ext/gl/gstglvideomixer.c b/ext/gl/gstglvideomixer.c
index 58142d5..580598c 100644
--- a/ext/gl/gstglvideomixer.c
+++ b/ext/gl/gstglvideomixer.c
@@ -346,10 +346,6 @@ _create_video_mixer_input (GstGLMixerBin * self, GstPad * mixer_pad)
       GST_OBJECT_NAME (mixer_pad), "direction", GST_PAD_DIRECTION (mixer_pad),
       NULL);
 
-  if (!gst_ghost_pad_construct (GST_GHOST_PAD (input))) {
-    gst_object_unref (input);
-    return NULL;
-  }
 #define ADD_BINDING(obj,ref,prop) \
     gst_object_add_control_binding (GST_OBJECT (obj), \
         gst_proxy_control_binding_new (GST_OBJECT (obj), prop, \
diff --git a/gst/playback/gstdecodebin2.c b/gst/playback/gstdecodebin2.c
index 65fdd24..aa0ec50 100644
--- a/gst/playback/gstdecodebin2.c
+++ b/gst/playback/gstdecodebin2.c
@@ -5223,7 +5223,6 @@ gst_decode_pad_new (GstDecodeBin * dbin, GstDecodeChain * chain)
   dpad =
       g_object_new (GST_TYPE_DECODE_PAD, "direction", GST_PAD_SRC,
       "template", pad_tmpl, NULL);
-  gst_ghost_pad_construct (GST_GHOST_PAD_CAST (dpad));
   dpad->chain = chain;
   dpad->dbin = dbin;
   gst_object_unref (pad_tmpl);
diff --git a/gst/playback/gstparsebin.c b/gst/playback/gstparsebin.c
index 825a821..4f9f8b6 100644
--- a/gst/playback/gstparsebin.c
+++ b/gst/playback/gstparsebin.c
@@ -4201,7 +4201,6 @@ gst_parse_pad_new (GstParseBin * parsebin, GstParseChain * chain)
   parsepad =
       g_object_new (GST_TYPE_PARSE_PAD, "direction", GST_PAD_SRC,
       "template", pad_tmpl, NULL);
-  gst_ghost_pad_construct (GST_GHOST_PAD_CAST (parsepad));
   parsepad->chain = chain;
   parsepad->parsebin = parsebin;
   gst_object_unref (pad_tmpl);