From: Leo (Sunpeng) Li Date: Fri, 12 Jan 2018 18:13:11 +0000 (-0500) Subject: drm/amd/display: Fix multiple definitions of handle_crc_irq X-Git-Tag: v5.15~8964^2~30^2~104 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fdb401d03d311399d844b9f23ec5ab98a2811f58;p=platform%2Fkernel%2Flinux-starfive.git drm/amd/display: Fix multiple definitions of handle_crc_irq If CONFIG_DEBUG_FS is disabled, then CRC should also be disabled. Therefore, amdgpu_dm_crtc_handle_crc_irq was redefined as a no-op function within amdgpu_dm.h. However, since amdgpu_dm.h is included in multiple files, this caused conflicts when linking during compile. Therefore, Use a macro to define the function as a no-op instead. Signed-off-by: Leo (Sunpeng) Li Reviewed-by: Harry Wentland Reviewed-by: Tony Cheng Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h index 2a24d25..99ae85e 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h @@ -265,7 +265,7 @@ int amdgpu_dm_crtc_set_crc_source(struct drm_crtc *crtc, const char *src_name, void amdgpu_dm_crtc_handle_crc_irq(struct drm_crtc *crtc); #else #define amdgpu_dm_crtc_set_crc_source NULL -void amdgpu_dm_crtc_handle_crc_irq(struct drm_crtc *crtc) {} +#define amdgpu_dm_crtc_handle_crc_irq(x) #endif extern const struct drm_encoder_helper_funcs amdgpu_dm_encoder_helper_funcs;