From: Carlos Chinea Date: Fri, 13 Apr 2012 13:03:03 +0000 (+0300) Subject: HSI: hsi_char: Remove max_data_size from sysfs X-Git-Tag: v3.4~136^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fdadb6e9a5cf65c7662b2ca817856f187d05ab7d;p=platform%2Fkernel%2Flinux-amlogic.git HSI: hsi_char: Remove max_data_size from sysfs Remove max_data_size sysfs entry. Otherwise is possible to have a buffer overrun if its value is increased after the device is open. Signed-off-by: Carlos Chinea Acked-by: Greg Kroah-Hartman Acked-by: Linus Walleij --- diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_char.c index 88a050d..3ad91f6 100644 --- a/drivers/hsi/clients/hsi_char.c +++ b/drivers/hsi/clients/hsi_char.c @@ -123,7 +123,7 @@ struct hsc_client_data { static unsigned int hsc_major; /* Maximum buffer size that hsi_char will accept from userspace */ static unsigned int max_data_size = 0x1000; -module_param(max_data_size, uint, S_IRUSR | S_IWUSR); +module_param(max_data_size, uint, 0); MODULE_PARM_DESC(max_data_size, "max read/write data size [4,8..65536] (^2)"); static void hsc_add_tail(struct hsc_channel *channel, struct hsi_msg *msg,