From: Geert Uytterhoeven Date: Tue, 15 Feb 2022 11:21:26 +0000 (+0100) Subject: video: fbdev: atari: Remove unused atafb_setcolreg() X-Git-Tag: v6.1-rc5~1764^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fdaae9fefb95b73d47fec00b40d688b2931076d1;p=platform%2Fkernel%2Flinux-starfive.git video: fbdev: atari: Remove unused atafb_setcolreg() atafb_probe() overrides the atafb_ops.fb_setcolreg() method to match the actual graphics hardware. Besides, the shifts by 8 were bogus, as the individual .fb_setcolreg() implementations already take care of that. Signed-off-by: Geert Uytterhoeven Signed-off-by: Helge Deller --- diff --git a/drivers/video/fbdev/atafb.c b/drivers/video/fbdev/atafb.c index b9d6aaa..e95333e 100644 --- a/drivers/video/fbdev/atafb.c +++ b/drivers/video/fbdev/atafb.c @@ -2404,16 +2404,6 @@ static void atafb_set_disp(struct fb_info *info) atari_stram_to_virt(info->fix.smem_start)); } -static int atafb_setcolreg(u_int regno, u_int red, u_int green, u_int blue, - u_int transp, struct fb_info *info) -{ - red >>= 8; - green >>= 8; - blue >>= 8; - - return info->fbops->fb_setcolreg(regno, red, green, blue, transp, info); -} - static int atafb_pan_display(struct fb_var_screeninfo *var, struct fb_info *info) { @@ -2724,7 +2714,6 @@ static struct fb_ops atafb_ops = { .owner = THIS_MODULE, .fb_check_var = atafb_check_var, .fb_set_par = atafb_set_par, - .fb_setcolreg = atafb_setcolreg, .fb_blank = atafb_blank, .fb_pan_display = atafb_pan_display, .fb_fillrect = atafb_fillrect,