From: Fabio Estevam Date: Wed, 18 Sep 2013 02:13:10 +0000 (-0300) Subject: net: fec_mxc: Fix timeouts during tftp transfer X-Git-Tag: v2013.10-rc4~1^2^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fd37f195cacc068ad4c070dd794643fcb25ef21a;p=platform%2Fkernel%2Fu-boot.git net: fec_mxc: Fix timeouts during tftp transfer Performing tftp transfers on mx28 results in random timeouts. Hector Palacios and Robert Hodaszi analyzed the root cause being related to the wrong alignment of the 'buff' buffer inside fec_recv(). Benoît Thébaudeau provided an excellent analysis of the alignment bug that is present on older versions, such as GCC 4.5.4: http://marc.info/?l=u-boot&m=137942904906131&w=2 Use ALLOC_CACHE_ALIGN_BUFFER() to avoid alignment issues from older GCC versions. Reported-by: Hector Palacios Tested-by: Oliver Metz Tested-by: Hector Palacios Signed-off-by: Fabio Estevam Acked-by: Marek Vasut Tested-by: Marek Vasut --- diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 210ef02..107cd6e 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -794,7 +794,7 @@ static int fec_recv(struct eth_device *dev) uint16_t bd_status; uint32_t addr, size, end; int i; - uchar buff[FEC_MAX_PKT_SIZE] __aligned(ARCH_DMA_MINALIGN); + ALLOC_CACHE_ALIGN_BUFFER(uchar, buff, FEC_MAX_PKT_SIZE); /* * Check if any critical events have happened