From: Alan Alpert <alan.alpert@nokia.com>
Date: Thu, 19 May 2011 08:02:21 +0000 (+1000)
Subject: Normalize createQmlObject error message
X-Git-Tag: qt-v5.0.0-alpha1~2170^2~92
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fcdd4d4dd565c4ec8b22d9ee5aa0ad2428a4336b;p=profile%2Fivi%2Fqtdeclarative.git

Normalize createQmlObject error message
---

diff --git a/src/declarative/qml/qdeclarativeengine.cpp b/src/declarative/qml/qdeclarativeengine.cpp
index 0018841..86b7e94 100644
--- a/src/declarative/qml/qdeclarativeengine.cpp
+++ b/src/declarative/qml/qdeclarativeengine.cpp
@@ -1398,7 +1398,7 @@ QScriptValue QDeclarativeEnginePrivate::createQmlObject(QScriptContext *ctxt, QS
         QScriptValue arr = ctxt->engine()->newArray(errors.length());
         int i = 0;
         foreach (const QDeclarativeError &error, errors){
-            errstr += QLatin1String("    ") + error.toString() + QLatin1String("\n");
+            errstr += QLatin1String("\n    ") + error.toString();
             QScriptValue qmlErrObject = ctxt->engine()->newObject();
             qmlErrObject.setProperty(QLatin1String("lineNumber"), QScriptValue(error.line()));
             qmlErrObject.setProperty(QLatin1String("columnNumber"), QScriptValue(error.column()));
@@ -1425,7 +1425,7 @@ QScriptValue QDeclarativeEnginePrivate::createQmlObject(QScriptContext *ctxt, QS
         QScriptValue arr = ctxt->engine()->newArray(errors.length());
         int i = 0;
         foreach (const QDeclarativeError &error, errors){
-            errstr += QLatin1String("    ") + error.toString() + QLatin1String("\n");
+            errstr += QLatin1String("\n    ") + error.toString();
             QScriptValue qmlErrObject = ctxt->engine()->newObject();
             qmlErrObject.setProperty(QLatin1String("lineNumber"), QScriptValue(error.line()));
             qmlErrObject.setProperty(QLatin1String("columnNumber"), QScriptValue(error.column()));
diff --git a/tests/auto/declarative/qdeclarativeqt/tst_qdeclarativeqt.cpp b/tests/auto/declarative/qdeclarativeqt/tst_qdeclarativeqt.cpp
index 80d9d93..e6024ea 100644
--- a/tests/auto/declarative/qdeclarativeqt/tst_qdeclarativeqt.cpp
+++ b/tests/auto/declarative/qdeclarativeqt/tst_qdeclarativeqt.cpp
@@ -412,11 +412,11 @@ void tst_qdeclarativeqt::createQmlObject()
     QDeclarativeComponent component(&engine, TEST_FILE("createQmlObject.qml"));
 
     QString warning1 = component.url().toString() + ":7: Error: Qt.createQmlObject(): Invalid arguments";
-    QString warning2 = component.url().toString()+ ":10: Error: Qt.createQmlObject() failed to create object:     " + TEST_FILE("inline").toString() + ":2:10: Blah is not a type\n";
-    QString warning3 = component.url().toString()+ ":11: Error: Qt.createQmlObject() failed to create object:     " + TEST_FILE("main.qml").toString() + ":4:1: Duplicate property name\n";
+    QString warning2 = component.url().toString()+ ":10: Error: Qt.createQmlObject() failed to create object: \n    " + TEST_FILE("inline").toString() + ":2:10: Blah is not a type";
+    QString warning3 = component.url().toString()+ ":11: Error: Qt.createQmlObject() failed to create object: \n    " + TEST_FILE("main.qml").toString() + ":4:1: Duplicate property name";
     QString warning4 = component.url().toString()+ ":9: Error: Qt.createQmlObject(): Missing parent object";
     QString warning5 = component.url().toString()+ ":8: Error: Qt.createQmlObject(): Invalid arguments";
-    QString warning6 = "RunTimeError:  Qt.createQmlObject() failed to create object:     " + TEST_FILE("inline").toString() + ":3: Cannot assign object type QObject with no default method\n";
+    QString warning6 = "RunTimeError:  Qt.createQmlObject() failed to create object: \n    " + TEST_FILE("inline").toString() + ":3: Cannot assign object type QObject with no default method";
 
     QTest::ignoreMessage(QtWarningMsg, qPrintable(warning1));
     QTest::ignoreMessage(QtWarningMsg, qPrintable(warning2));