From: Markus Elfring Date: Tue, 18 Nov 2014 20:03:13 +0000 (+0100) Subject: netlink: Deletion of an unnecessary check before the function call "__module_get" X-Git-Tag: v4.9.8~5202^2~162 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fcd4d35ecc1636c8ac50e3a6266a620eb8ff0626;p=platform%2Fkernel%2Flinux-rpi3.git netlink: Deletion of an unnecessary check before the function call "__module_get" The __module_get() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: David S. Miller --- diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index d479b32..e1aad6e 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -142,8 +142,7 @@ int netlink_add_tap(struct netlink_tap *nt) list_add_rcu(&nt->list, &netlink_tap_all); spin_unlock(&netlink_tap_lock); - if (nt->module) - __module_get(nt->module); + __module_get(nt->module); return 0; }