From: Andrzej Hajda Date: Fri, 7 Aug 2015 07:59:11 +0000 (+0200) Subject: powerpc/nvram: use kmemdup rather than duplicating its implementation X-Git-Tag: v4.14-rc1~4767^2~26 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fc9e9cbf4e48f28525edd27e285820988f1a54b1;p=platform%2Fkernel%2Flinux-rpi.git powerpc/nvram: use kmemdup rather than duplicating its implementation The patch was generated using fixed coccinelle semantic patch scripts/coccinelle/api/memdup.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 Signed-off-by: Andrzej Hajda Reviewed-by: Nathan Fontenot Signed-off-by: Michael Ellerman --- diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c index 1e703f8..6f6597b3 100644 --- a/arch/powerpc/kernel/nvram_64.c +++ b/arch/powerpc/kernel/nvram_64.c @@ -541,10 +541,9 @@ static ssize_t nvram_pstore_read(u64 *id, enum pstore_type_id *type, time->tv_sec = be64_to_cpu(oops_hdr->timestamp); time->tv_nsec = 0; } - *buf = kmalloc(length, GFP_KERNEL); + *buf = kmemdup(buff + hdr_size, length, GFP_KERNEL); if (*buf == NULL) return -ENOMEM; - memcpy(*buf, buff + hdr_size, length); kfree(buff); if (err_type == ERR_TYPE_KERNEL_PANIC_GZ)