From: Víctor Manuel Jáquez Leal Date: Thu, 12 Nov 2015 15:13:25 +0000 (+0100) Subject: vaapipostproc: params video_info_changed() callers X-Git-Tag: 1.19.3~503^2~1583 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fc958520c328641b74ca04b6a416f0c77b8fddc7;p=platform%2Fupstream%2Fgstreamer.git vaapipostproc: params video_info_changed() callers The signature is video_info_changed(old_vip, new_vip). Nonetheless the callers swapped the the order. This didn't raise problems since the comparison of both structures were not affected by its semantics. But still it would be better to fix this to keep the coherence of the code. Signed-off-by: Víctor Manuel Jáquez Leal https://bugzilla.gnome.org/show_bug.cgi?id=758007 --- diff --git a/gst/vaapi/gstvaapipostproc.c b/gst/vaapi/gstvaapipostproc.c index 38fa9b5..18f3474 100644 --- a/gst/vaapi/gstvaapipostproc.c +++ b/gst/vaapi/gstvaapipostproc.c @@ -867,7 +867,7 @@ gst_vaapipostproc_update_sink_caps (GstVaapiPostproc * postproc, GstCaps * caps, if (!gst_video_info_from_caps (&vi, caps)) return FALSE; - if (video_info_changed (&vi, &postproc->sinkpad_info)) + if (video_info_changed (&postproc->sinkpad_info, &vi)) postproc->sinkpad_info = vi, *caps_changed_ptr = TRUE; deinterlace = is_deinterlace_enabled (postproc, &vi); @@ -892,7 +892,7 @@ gst_vaapipostproc_update_src_caps (GstVaapiPostproc * postproc, GstCaps * caps, if (!gst_video_info_from_caps (&vi, caps)) return FALSE; - if (video_info_changed (&vi, &postproc->srcpad_info)) + if (video_info_changed (&postproc->srcpad_info, &vi)) postproc->srcpad_info = vi, *caps_changed_ptr = TRUE; if (postproc->format != GST_VIDEO_INFO_FORMAT (&postproc->sinkpad_info) && @@ -1217,7 +1217,7 @@ ensure_srcpad_buffer_pool (GstVaapiPostproc * postproc, GstCaps * caps) GST_VIDEO_INFO_WIDTH (&vi), GST_VIDEO_INFO_HEIGHT (&vi)); if (postproc->filter_pool - && !video_info_changed (&vi, &postproc->filter_pool_info)) + && !video_info_changed (&postproc->filter_pool_info, &vi)) return TRUE; postproc->filter_pool_info = vi;