From: Hans de Goede <hdegoede@redhat.com>
Date: Wed, 29 Dec 2021 23:14:23 +0000 (+0100)
Subject: platform/x86: x86-android-tablets: Don't return -EPROBE_DEFER from a non probe()... 
X-Git-Tag: v6.1-rc5~2286^2~12
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fc64a2b21603dc1e1bae6f34b4bccfadc992894f;p=platform%2Fkernel%2Flinux-starfive.git

platform/x86: x86-android-tablets: Don't return -EPROBE_DEFER from a non probe() function

The x86-android-tablets code all runs from module_init, so returning
-EPROBE_DEFER is not appropriate. Instead log an error and bail.

This path should never get hit since PINCTRL_BAYTRAIL is a bool.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20211229231431.437982-5-hdegoede@redhat.com
---

diff --git a/drivers/platform/x86/x86-android-tablets.c b/drivers/platform/x86/x86-android-tablets.c
index 4a04da2..ea033d7 100644
--- a/drivers/platform/x86/x86-android-tablets.c
+++ b/drivers/platform/x86/x86-android-tablets.c
@@ -63,8 +63,10 @@ static int x86_acpi_irq_helper_get(const struct x86_acpi_irq_data *data)
 	case X86_ACPI_IRQ_TYPE_GPIOINT:
 		/* Like acpi_dev_gpio_irq_get(), but without parsing ACPI resources */
 		chip = gpiochip_find(data->chip, x86_acpi_irq_helper_gpiochip_find);
-		if (!chip)
-			return -EPROBE_DEFER;
+		if (!chip) {
+			pr_err("error cannot find GPIO chip %s\n", data->chip);
+			return -ENODEV;
+		}
 
 		gpiod = gpiochip_get_desc(chip, data->index);
 		if (IS_ERR(gpiod)) {