From: Kees Cook Date: Tue, 11 Mar 2014 20:26:16 +0000 (-0700) Subject: usb: gadget: tcm_usb_gadget: stop format strings X-Git-Tag: v3.10.39~29 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fc363768acb132a959ccf86fa2ea303862113c07;p=platform%2Fkernel%2Flinux-stable.git usb: gadget: tcm_usb_gadget: stop format strings commit aba37fd975f0dd58e025c99c2a79b61b20190831 upstream. This makes sure that the name coming out of configfs cannot be used accidentally as a format string. Signed-off-by: Kees Cook Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/gadget/tcm_usb_gadget.c b/drivers/usb/gadget/tcm_usb_gadget.c index 7cacd6a..e4d8d79 100644 --- a/drivers/usb/gadget/tcm_usb_gadget.c +++ b/drivers/usb/gadget/tcm_usb_gadget.c @@ -1614,7 +1614,7 @@ static struct se_wwn *usbg_make_tport( return ERR_PTR(-ENOMEM); } tport->tport_wwpn = wwpn; - snprintf(tport->tport_name, sizeof(tport->tport_name), wnn_name); + snprintf(tport->tport_name, sizeof(tport->tport_name), "%s", wnn_name); return &tport->tport_wwn; }