From: Georg Lehmann <dadschoorse@gmail.com>
Date: Tue, 31 Jan 2023 17:04:29 +0000 (+0100)
Subject: aco/ra: set opsel_hi to zero when converting to VOP2
X-Git-Tag: upstream/23.3.3~12034
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fc193ab4dbb9fd7e3f45a14c333ef5403fad7f56;p=platform%2Fupstream%2Fmesa.git

aco/ra: set opsel_hi to zero when converting to VOP2

Otherwise the new modifier validation will fail.

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21023>
---

diff --git a/src/amd/compiler/aco_register_allocation.cpp b/src/amd/compiler/aco_register_allocation.cpp
index 54d4174..5a7adb3 100644
--- a/src/amd/compiler/aco_register_allocation.cpp
+++ b/src/amd/compiler/aco_register_allocation.cpp
@@ -2637,6 +2637,7 @@ optimize_encoding_vop2(Program* program, ra_ctx& ctx, RegisterFile& register_fil
    static_assert(sizeof(VOP2_instruction) <= sizeof(VOP3P_instruction),
                  "Invalid direct instruction cast.");
    instr->format = Format::VOP2;
+   instr->valu().opsel_hi = 0;
    switch (instr->opcode) {
    case aco_opcode::v_mad_f32: instr->opcode = aco_opcode::v_mac_f32; break;
    case aco_opcode::v_fma_f32: instr->opcode = aco_opcode::v_fmac_f32; break;