From: Sander Vanheule Date: Tue, 23 Aug 2022 06:12:20 +0000 (+0200) Subject: lib/test_cpumask: fix cpu_possible_mask last test X-Git-Tag: v6.1-rc5~515^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fbbc94d8486c6d683650269154c9a7d8897f35d7;p=platform%2Fkernel%2Flinux-starfive.git lib/test_cpumask: fix cpu_possible_mask last test Since cpumask_first() on the cpu_possible_mask must return at most nr_cpu_ids - 1 for a valid result, cpumask_last() cannot return anything larger than this value. As test_cpumask_weight() also verifies that the total weight of cpu_possible_mask must equal nr_cpu_ids, the last bit set in this mask must be at nr_cpu_ids - 1. Fixes: c41e8866c28c ("lib/test: introduce cpumask KUnit test suite") Link: https://lore.kernel.org/lkml/346cb279-8e75-24b0-7d12-9803f2b41c73@riseup.net/ Reported-by: Maíra Canal Signed-off-by: Sander Vanheule Tested-by: Maíra Canal Reviewed-by: David Gow Acked-by: Yury Norov Signed-off-by: Yury Norov --- diff --git a/lib/test_cpumask.c b/lib/test_cpumask.c index 4ebf9f5..4d35361 100644 --- a/lib/test_cpumask.c +++ b/lib/test_cpumask.c @@ -73,7 +73,7 @@ static void test_cpumask_first(struct kunit *test) static void test_cpumask_last(struct kunit *test) { KUNIT_EXPECT_LE(test, nr_cpumask_bits, cpumask_last(&mask_empty)); - KUNIT_EXPECT_EQ(test, nr_cpumask_bits - 1, cpumask_last(cpu_possible_mask)); + KUNIT_EXPECT_EQ(test, nr_cpu_ids - 1, cpumask_last(cpu_possible_mask)); } static void test_cpumask_next(struct kunit *test)