From: Ilya Dryomov <ilya.dryomov@inktank.com>
Date: Fri, 27 Jun 2014 17:46:33 +0000 (+0400)
Subject: rbd: do not leak image_id in rbd_dev_v2_parent_info()
X-Git-Tag: v4.14-rc1~7028^2~23
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fbba11b3bec52ff560cb42d102f61341049defb0;p=platform%2Fkernel%2Flinux-rpi.git

rbd: do not leak image_id in rbd_dev_v2_parent_info()

image_id is leaked if the parent happens to have been recorded already.
Fix it.

Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
Reviewed-by: Alex Elder <elder@linaro.org>
---

diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index d99aa81..adedb39 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -4072,6 +4072,8 @@ static int rbd_dev_v2_parent_info(struct rbd_device *rbd_dev)
 		parent_spec->snap_id = snap_id;
 		rbd_dev->parent_spec = parent_spec;
 		parent_spec = NULL;	/* rbd_dev now owns this */
+	} else {
+		kfree(image_id);
 	}
 
 	/*