From: Mike Miller Date: Thu, 13 Oct 2011 16:44:06 +0000 (-0500) Subject: [SCSI] hpsa: change confusing message to be more clear X-Git-Tag: upstream/snapshot3+hdmi~8885^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fba63097b8614a4a158226c02eec0318f41cd24f;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git [SCSI] hpsa: change confusing message to be more clear The following warning message may be confusing to some users: dev_warn(&pdev->dev, "Controller claims that " "'Bit 2 doorbell reset' is " "supported, but not 'bit 5 doorbell reset'. " "Firmware update is recommended.\n"); Most users don't know or care what bit we may be hitting. Also change "recommended" to "required." Signed-off-by: Mike Miller Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index b200b73..9825ecf 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -3438,10 +3438,8 @@ static __devinit int hpsa_kdump_hard_reset_controller(struct pci_dev *pdev) } else { use_doorbell = misc_fw_support & MISC_FW_DOORBELL_RESET; if (use_doorbell) { - dev_warn(&pdev->dev, "Controller claims that " - "'Bit 2 doorbell reset' is " - "supported, but not 'bit 5 doorbell reset'. " - "Firmware update is recommended.\n"); + dev_warn(&pdev->dev, "Soft reset not supported. " + "Firmware update is required.\n"); rc = -ENOTSUPP; /* try soft reset */ goto unmap_cfgtable; }