From: mtklein Date: Thu, 2 Apr 2015 22:41:25 +0000 (-0700) Subject: Revert of Try ARMv7 and NEON for Daisy. (patchset #1 id:1 of https://codereview.chrom... X-Git-Tag: accepted/tizen/5.0/unified/20181102.025319~2907 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fb806dd27d93d09a1aedac6c4666f4424c7d9c7d;p=platform%2Fupstream%2FlibSkiaSharp.git Revert of Try ARMv7 and NEON for Daisy. (patchset #1 id:1 of https://codereview.chromium.org/1054233002/) Reason for revert: whatever compiler we're using can't handle array subscripts for neon vectors Original issue's description: > Try ARMv7 and NEON for Daisy. > > I think Daisy's color order problems are in non-NEON ARM assembly. > NEON might actually be fine. > > BUG=skia:1843 > > Committed: https://skia.googlesource.com/skia/+/a121c0ee6b911dd7004c6054a8692d37084b6b3d TBR=mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:1843 Review URL: https://codereview.chromium.org/1058173002 --- diff --git a/platform_tools/chromeos/bin/chromeos_setup.sh b/platform_tools/chromeos/bin/chromeos_setup.sh index b04eb1b..de4d6f9 100755 --- a/platform_tools/chromeos/bin/chromeos_setup.sh +++ b/platform_tools/chromeos/bin/chromeos_setup.sh @@ -34,7 +34,8 @@ setup_device() { GENERIC_BOARD_TYPE="amd64-generic" ;; daisy) - DEFINES="${DEFINES} skia_arch_type=arm arm_version=7 arm_neon=1" + # TODO(mtklein): make this arm_version=7 arm_neon=1 + DEFINES="${DEFINES} skia_arch_type=arm" # TODO(borenet): We have to define skia_warnings_as_errors=0 for the arm # build, which throws lots of "mangling of va_list has changed" warnings. DEFINES="${DEFINES} skia_warnings_as_errors=0"