From: Hans de Goede Date: Mon, 18 Nov 2019 15:51:32 +0000 (+0100) Subject: drm/modes: parse_cmdline: Explicitly memset the passed in drm_cmdline_mode struct X-Git-Tag: accepted/tizen/unified/20200709.164653~729 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fb72df9576f80952adf43ce1bf1ea95edcb7e0c9;p=platform%2Fkernel%2Flinux-rpi.git drm/modes: parse_cmdline: Explicitly memset the passed in drm_cmdline_mode struct Commit d1fe276b5115f0d581c3cfe6154633b3547e8aab upstream. Instead of only setting mode->specified on false on an early exit and leaving e.g. mode->bpp_specified and mode->refresh_specified as is, lets be consistent and just zero out the entire passed in struct at the top of drm_mode_parse_command_line_for_connector() Changes in v3: -Drop "mode->specified = false;" line instead of the "return false;" (oops) This crasher was reported-by: kernel test robot Acked-by: Maxime Ripard Signed-off-by: Hans de Goede Link: https://patchwork.freedesktop.org/patch/msgid/20191118155134.30468-11-hdegoede@redhat.com --- diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 9914961..afc0ee9 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -1752,12 +1752,11 @@ bool drm_mode_parse_command_line_for_connector(const char *mode_option, char *bpp_end_ptr = NULL, *refresh_end_ptr = NULL; int i, len, ret; + memset(mode, 0, sizeof(*mode)); mode->panel_orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN; - if (!mode_option) { - mode->specified = false; + if (!mode_option) return false; - } name = mode_option;