From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 10 Jul 2017 08:47:40 +0000 (+0300)
Subject: scsi: qla2xxx: Off by one in qlt_ctio_to_cmd()
X-Git-Tag: v4.14-rc1~205^2~33
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fb2028a0b24e0823bbc0a28e6f0f1bd9fbbf733c;p=platform%2Fkernel%2Flinux-rpi.git

scsi: qla2xxx: Off by one in qlt_ctio_to_cmd()

There are "req->num_outstanding_cmds" elements in the
req->outstanding_cmds[] array so the > here should be >=.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---

diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 2a0173e..986a427 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -3747,7 +3747,7 @@ static struct qla_tgt_cmd *qlt_ctio_to_cmd(struct scsi_qla_host *vha,
 	h &= QLA_CMD_HANDLE_MASK;
 
 	if (h != QLA_TGT_NULL_HANDLE) {
-		if (unlikely(h > req->num_outstanding_cmds)) {
+		if (unlikely(h >= req->num_outstanding_cmds)) {
 			ql_dbg(ql_dbg_tgt, vha, 0xe052,
 			    "qla_target(%d): Wrong handle %x received\n",
 			    vha->vp_idx, handle);