From: Jason Yan Date: Sun, 26 Apr 2020 09:41:15 +0000 (+0800) Subject: rtlwifi: use true,false for bool variable in rtl_init_rfkill() X-Git-Tag: v5.15~3723^2~261^2~21 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fb1a9fc550cf748ba1225d734539ae97b5699b02;p=platform%2Fkernel%2Flinux-starfive.git rtlwifi: use true,false for bool variable in rtl_init_rfkill() The 'blocked' is a bool variable, and '==' expression itself is bool too. So no need to convert it to 0/1. This fixes the following coccicheck warning: drivers/net/wireless/realtek/rtlwifi/base.c:508:13-41: WARNING: Comparison of 0/1 to bool variable Signed-off-by: Jason Yan Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20200426094115.23294-1-yanaijie@huawei.com --- diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c index c75192c..a4489b9 100644 --- a/drivers/net/wireless/realtek/rtlwifi/base.c +++ b/drivers/net/wireless/realtek/rtlwifi/base.c @@ -505,7 +505,7 @@ void rtl_init_rfkill(struct ieee80211_hw *hw) rtlpriv->rfkill.rfkill_state = radio_state; - blocked = (rtlpriv->rfkill.rfkill_state == 1) ? 0 : 1; + blocked = rtlpriv->rfkill.rfkill_state != 1; wiphy_rfkill_set_hw_state(hw->wiphy, blocked); }