From: Minchan Kim Date: Mon, 3 Mar 2014 23:38:34 +0000 (-0800) Subject: zram: avoid null access when fail to alloc meta X-Git-Tag: submit/tizen_common/20140905.094502~422 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=faf65d4dccfd705ff302e4e7b59fcb454f3b47ce;p=sdk%2Femulator%2Femulator-kernel.git zram: avoid null access when fail to alloc meta commit db5d711e2db776f18219b033e5dc4fb7e4264dd7 upstream. zram_meta_alloc could fail so caller should check it. Otherwise, your system will hang. Signed-off-by: Minchan Kim Acked-by: Jerome Marchand Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Jiri Slaby --- diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c index d7ac040e0dc1..d02088f7dc33 100644 --- a/drivers/staging/zram/zram_drv.c +++ b/drivers/staging/zram/zram_drv.c @@ -621,6 +621,8 @@ static ssize_t disksize_store(struct device *dev, disksize = PAGE_ALIGN(disksize); meta = zram_meta_alloc(disksize); + if (!meta) + return -ENOMEM; down_write(&zram->init_lock); if (zram->init_done) { up_write(&zram->init_lock);