From: dkdk-ryu <38246983+dkdk-ryu@users.noreply.github.com> Date: Tue, 18 Jan 2022 02:47:43 +0000 (+0900) Subject: [NUI] Modify GLWindow's method names (#3862) X-Git-Tag: accepted/tizen/unified/20231205.024657~1204 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fae398e65766dfc40db75d04194b3c23e92182af;p=platform%2Fcore%2Fcsapi%2Ftizenfx.git [NUI] Modify GLWindow's method names (#3862) It copied the naming style from GLView. It depends on https://review.tizen.org/gerrit/c/platform/core/uifw/dali-adaptor/+/268653 https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/268654 --- diff --git a/src/Tizen.NUI/src/internal/Interop/Interop.GLWindow.cs b/src/Tizen.NUI/src/internal/Interop/Interop.GLWindow.cs index c6043b8..a627ae2 100755 --- a/src/Tizen.NUI/src/internal/Interop/Interop.GLWindow.cs +++ b/src/Tizen.NUI/src/internal/Interop/Interop.GLWindow.cs @@ -41,8 +41,8 @@ namespace Tizen.NUI [DllImport(NDalicPINVOKE.Lib, EntryPoint = "CSharp_Dali_GlWindow_Assign")] public static extern global::System.IntPtr GlWindowAssign(HandleRef jarg1, HandleRef jarg2); - [DllImport(NDalicPINVOKE.Lib, EntryPoint = "CSharp_Dali_GlWindow_SetEglConfig")] - public static extern global::System.IntPtr GlWindowSetEglConfig(HandleRef jarg1, bool jarg2, bool jarg3, int jarg4, int jarg5); + [DllImport(NDalicPINVOKE.Lib, EntryPoint = "CSharp_Dali_GlWindow_SetGraphicsConfig")] + public static extern global::System.IntPtr GlWindowSetGraphicsConfig(HandleRef jarg1, bool jarg2, bool jarg3, int jarg4, int jarg5); [DllImport(NDalicPINVOKE.Lib, EntryPoint = "CSharp_Dali_GlWindow_Raise")] public static extern void GlWindowRaise(HandleRef jarg1); @@ -107,8 +107,8 @@ namespace Tizen.NUI [DllImport(NDalicPINVOKE.Lib, EntryPoint = "CSharp_Dali_GlWindow_SetPreferredOrientation")] public static extern void GlWindowSetPreferredOrientation(HandleRef jarg1, int jarg2); - [DllImport(NDalicPINVOKE.Lib, EntryPoint = "CSharp_Dali_GlWindow_RegisterGlCallback")] - public static extern void GlWindowRegisterGlCallback(HandleRef jarg1, HandleRef jarg2, HandleRef jarg3, HandleRef jarg4); + [DllImport(NDalicPINVOKE.Lib, EntryPoint = "CSharp_Dali_GlWindow_RegisterGlCallbacks")] + public static extern void GlWindowRegisterGlCallbacks(HandleRef jarg1, HandleRef jarg2, HandleRef jarg3, HandleRef jarg4); [DllImport(NDalicPINVOKE.Lib, EntryPoint = "CSharp_Dali_GlWindow_RenderOnce")] public static extern void GlWindowRenderOnce(HandleRef jarg1); diff --git a/src/Tizen.NUI/src/public/Window/GLWindow.cs b/src/Tizen.NUI/src/public/Window/GLWindow.cs index a2a7f8e..a5c9467 100755 --- a/src/Tizen.NUI/src/public/Window/GLWindow.cs +++ b/src/Tizen.NUI/src/public/Window/GLWindow.cs @@ -136,16 +136,16 @@ namespace Tizen.NUI } /// - /// Sets egl configuration for GLWindow + /// Sets graphics configuration for GLWindow /// /// The flag of depth buffer. If true is set, 24bit depth buffer is enabled. /// The flag of stencil. it true is set, 8bit stencil buffer is enabled. /// The bit of msaa. /// The GLES version. [EditorBrowsable(EditorBrowsableState.Never)] - public void SetEglConfig(bool depth, bool stencil, int msaa, GLESVersion version) + public void SetGraphicsConfig(bool depth, bool stencil, int msaa, GLESVersion version) { - Interop.GLWindow.GlWindowSetEglConfig(SwigCPtr, depth, stencil, msaa, (int)version); + Interop.GLWindow.GlWindowSetGraphicsConfig(SwigCPtr, depth, stencil, msaa, (int)version); if (NDalicPINVOKE.SWIGPendingException.Pending) throw NDalicPINVOKE.SWIGPendingException.Retrieve(); } @@ -443,13 +443,13 @@ namespace Tizen.NUI HandleRef TerminateHandlerRef; /// - /// Registers a GL callback function for application. + /// Registers GL callback functions for application. /// /// The callback function for application initialize /// The callback function to render to the frame /// The callback function to clean-up application GL resource [EditorBrowsable(EditorBrowsableState.Never)] - public void RegisterGlCallback(GLInitializeCallbackType glInit, GLRenderFrameCallbackType glRenderFrame, GLTerminateCallbackType glTerminate) + public void RegisterGLCallbacks(GLInitializeCallbackType glInit, GLRenderFrameCallbackType glRenderFrame, GLTerminateCallbackType glTerminate) { GLInitializeCallback = glInit; InitHandleRef = new HandleRef(this, Marshal.GetFunctionPointerForDelegate(GLInitializeCallback)); @@ -460,7 +460,7 @@ namespace Tizen.NUI GLTerminateCallback = glTerminate; TerminateHandlerRef = new HandleRef(this, Marshal.GetFunctionPointerForDelegate(GLTerminateCallback)); - Interop.GLWindow.GlWindowRegisterGlCallback(SwigCPtr, InitHandleRef, RenderHandlerRef, TerminateHandlerRef); + Interop.GLWindow.GlWindowRegisterGlCallbacks(SwigCPtr, InitHandleRef, RenderHandlerRef, TerminateHandlerRef); if (NDalicPINVOKE.SWIGPendingException.Pending) throw NDalicPINVOKE.SWIGPendingException.Retrieve(); }