From: INSUN PYO Date: Thu, 27 Jun 2019 02:32:36 +0000 (+0900) Subject: Delete the code that should not run X-Git-Tag: submit/tizen/20190627.081751^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fad12202b81f7a5e48f5fe8afff2b179eed5332e;p=sdk%2Ftarget%2Fsdbd.git Delete the code that should not run /home/owner has a media directory which is the root owner. So, you should never do "chown owner:owner /home/owner" ////////////////////////////////////////////////////////////////// sh-3.2# ls -al /home/owner/ total 44 drwxr-x--- 11 owner system_share 4096 Jun 26 2019 . drwxr-xr-x 3 root root 4096 Jun 26 2019 .. drwxr-x--- 6 owner system_share 4096 Jun 26 2019 .applications drwxrwxr-x 4 owner users 4096 Jan 1 2015 .cache drwxrwxr-x 4 owner users 4096 Jan 1 2015 .config drwxr-xr-x 2 owner users 4096 Jun 26 2019 .dotnet drwxr-xr-x 3 owner users 4096 Jun 26 2019 .pki drwxr-x--- 99 owner system_share 4096 Jun 26 2019 apps_rw drwxrwxr-x 7 owner users 4096 Jan 1 2015 data drwxrwsrwx 11 root priv_mediastorage 4096 Jun 26 2019 media drwxrwxr-x 7 owner users 4096 Jan 1 2015 share //////////////////////////////////////////////////////////////////// Change-Id: I17e90ab16ee0f3c2c04492aa53bed927e6f92092 --- diff --git a/src/sdb.c b/src/sdb.c index 6fe13a5..42a3bec 100644 --- a/src/sdb.c +++ b/src/sdb.c @@ -1715,8 +1715,6 @@ static int safe_system(char *cmd, char *argv[], char *envp[]) { } static void init_sdk_requirements() { - struct stat st; - // set env variable for temporary // TODO: should use pam instead later!! putenv("TERM=linux"); @@ -1725,40 +1723,6 @@ static void init_sdk_requirements() { init_sdk_userinfo(); init_root_userinfo(); - if (g_sdk_home_dir != NULL && stat(g_sdk_home_dir, &st) == 0) { - if (st.st_uid != g_sdk_user_id || st.st_gid != g_sdk_group_id) { - char* cmd = "/usr/bin/chown"; - char params[128]; - char* envp[128]; - int envp_cnt = 0; - int i = 0; - - envp[envp_cnt++] = g_strdup("TERM=linux"); - envp[envp_cnt++] = g_strdup("DISPLAY=:0"); - envp[envp_cnt] = NULL; - - snprintf(params, sizeof(params), "%s %s:%s %s -R", cmd, SDK_USER_NAME, SDK_USER_NAME, g_sdk_home_dir); - - char* args[] = { - cmd, - params, - NULL, - }; - if (safe_system(cmd, args, envp) < 0) { - E("failed to change ownership to sdk user to %s\n", g_sdk_home_dir); - } - - /* free environment variables */ - if (envp_cnt > 0) { - for (i = 0; i < envp_cnt; i++) { - if (envp[i]) { - g_free(envp[i]); - } - } - } - } - } - if (is_emulator()) { register_bootdone_cb(); }