From: Matthew Barnes Date: Wed, 7 Nov 2012 12:53:56 +0000 (-0500) Subject: Disable runtime check in source_registry_initable_init(). X-Git-Tag: upstream/3.7.4~234 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fab2ee606fad729edafc9a22379a26c01b1f0eb5;p=platform%2Fupstream%2Fevolution-data-server.git Disable runtime check in source_registry_initable_init(). Rationale explained in the source code. --- diff --git a/libedataserver/e-source-registry.c b/libedataserver/e-source-registry.c index 3077f57..cbaf89b 100644 --- a/libedataserver/e-source-registry.c +++ b/libedataserver/e-source-registry.c @@ -1061,8 +1061,24 @@ source_registry_initable_init (GInitable *initable, return FALSE; } - /* The registry should now be populated with sources. */ - g_warn_if_fail (g_hash_table_size (registry->priv->sources) > 0); + /* The registry should now be populated with sources. + * + * XXX Actually, not necessarily if the registry service was + * just now activated. There may yet be a small window + * while the registry service starts up before it exports + * any sources, even built-in sources. This COULD create + * problems if any logic that depends on those built-in + * sources executes during this time window, but so far + * we haven't seen any cases of that. + * + * Attempts in the past to stop and wait for sources to + * show up have proven problematic. See for example: + * https://bugzilla.gnome.org/678378 + * + * Leave the runtime check disabled for the moment. + * I have a feeling I'll be revisiting this again. + */ + /*g_warn_if_fail (g_hash_table_size (registry->priv->sources) > 0);*/ /* The EDBusSourceManagerProxy is just another D-Bus interface * that resides at the same object path. It's unrelated to the