From: Tomasz Marciniak <t.marciniak@samsung.com>
Date: Fri, 2 Dec 2016 10:20:04 +0000 (+0900)
Subject: [Convergence] Return InvalidValuesError if id is empty.
X-Git-Tag: submit/tizen/20161206.092612^2~2^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fa7e3ee6dbda59eaec352eeed8fb82dc2e721400;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git

[Convergence] Return InvalidValuesError if id is empty.

[Verification] Code compiles. Proper error is returned
in error callback.

Change-Id: I55c6c7fbb786022bdbe882bd9ee99cae0654242b
Signed-off-by: Tomasz Marciniak <t.marciniak@samsung.com>
---

diff --git a/src/convergence/convergence_instance.cc b/src/convergence/convergence_instance.cc
index 622d8505..4ad3807b 100644
--- a/src/convergence/convergence_instance.cc
+++ b/src/convergence/convergence_instance.cc
@@ -359,9 +359,12 @@ common::TizenResult ConvergenceInstance::RemoteAppControlServiceLaunch(const pic
       result = LogAndCreateTizenError(AbortError, "Can not find the service type = 1",
         ("Can not find the service type = 1"));
     } else {
-      result = service->Launch(
-                  ConvergenceUtils::GetArg(args, kJSArgumentAppId).to_str().c_str(),
-                  static_cast<int>(ConvergenceUtils::GetArg(args, kJSCurrentListenerId).get<double>()));
+      std::string id = ConvergenceUtils::GetArg(args, kJSArgumentAppId).to_str();
+      if (id.empty()) {
+        result = LogAndCreateTizenError(InvalidValuesError, "Invalid app id", ("Invalid app id"));
+      } else {
+        result = service->Launch(id.c_str(), static_cast<int>(ConvergenceUtils::GetArg(args, kJSCurrentListenerId).get<double>()));
+      }
     }
 
     //only in case of failure call callback