From: Matt Fleming Date: Wed, 21 Mar 2012 23:33:44 +0000 (-0700) Subject: xtensa: don't reimplement force_sigsegv() X-Git-Tag: v3.4-rc1~158^2~87 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fa47ac59020e91082386f65a01f3e8cc6116ef95;p=platform%2Fkernel%2Flinux-stable.git xtensa: don't reimplement force_sigsegv() Instead of open coding the sequence from force_sigsegv() just call it. This also fixes a bug because we were modifying ka->sa.sa_handler (which is a copy of sighand->action[]), whereas the intention of the code was to modify sighand->action[] directly. As the original code was working with a copy it had no effect on signal delivery. Acked-by: Oleg Nesterov Cc: Chris Zankel Signed-off-by: Matt Fleming Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/arch/xtensa/kernel/signal.c b/arch/xtensa/kernel/signal.c index f2220b5..4f53770 100644 --- a/arch/xtensa/kernel/signal.c +++ b/arch/xtensa/kernel/signal.c @@ -425,9 +425,7 @@ static void setup_frame(int sig, struct k_sigaction *ka, siginfo_t *info, return; give_sigsegv: - if (sig == SIGSEGV) - ka->sa.sa_handler = SIG_DFL; - force_sig(SIGSEGV, current); + force_sigsegv(sig, current); } /*