From: reed Date: Wed, 13 Jan 2016 18:43:09 +0000 (-0800) Subject: remove CreateLightingFilter from SkColorFilter X-Git-Tag: accepted/tizen/5.0/unified/20181102.025319~184^2~39 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fa2b3a376d93e1d611e48c3c2f31ec3198d53600;p=platform%2Fupstream%2FlibSkiaSharp.git remove CreateLightingFilter from SkColorFilter All callers have converted over to SkColorMatrixFilter BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1583923002 Review URL: https://codereview.chromium.org/1583923002 --- diff --git a/include/core/SkColorFilter.h b/include/core/SkColorFilter.h index e89b2b1..c5d084a 100644 --- a/include/core/SkColorFilter.h +++ b/include/core/SkColorFilter.h @@ -106,9 +106,6 @@ public: */ static SkColorFilter* CreateModeFilter(SkColor c, SkXfermode::Mode mode); - // DEPRECATED -- call this from SkColorMatrixFilter instead -- see skbug.com/4791 - static SkColorFilter* CreateLightingFilter(SkColor mul, SkColor add); - /** Construct a colorfilter whose effect is to first apply the inner filter and then apply * the outer filter to the result of the inner's. * The reference counts for outer and inner are incremented. diff --git a/src/effects/SkColorMatrixFilter.cpp b/src/effects/SkColorMatrixFilter.cpp index f24670e..ce6ca55 100644 --- a/src/effects/SkColorMatrixFilter.cpp +++ b/src/effects/SkColorMatrixFilter.cpp @@ -362,8 +362,3 @@ SkColorFilter* SkColorMatrixFilter::CreateLightingFilter(SkColor mul, SkColor ad 0); return SkColorMatrixFilter::Create(matrix); } - -// DEPRECTED -- remove this when chrome/android stop calling it -SkColorFilter* SkColorFilter::CreateLightingFilter(SkColor mul, SkColor add) { - return SkColorMatrixFilter::CreateLightingFilter(mul, add); -}