From: ws29.jung Date: Tue, 14 Apr 2020 08:02:09 +0000 (+0900) Subject: [Addon] Fix showMessageBox function X-Git-Tag: submit/tizen_5.5/20200625.010053~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fa2ab88d9cda40b0bf18078a530ff16c42837d73;p=platform%2Fframework%2Fweb%2Fwrtjs.git [Addon] Fix showMessageBox function Old version of Electron only had 'showMessageBox' function, and it handled sync and async mode under binded C++ function. Now new Electron export 'showMessageBoxSync' function separatly and it works as sync mode of old 'showMessageBox'. To handle both functions with one source code, this patch makes addonapi method to use logical function fallback. Change-Id: I36a73106d451672c51c3aebbd1ecb92a25be3c02 Signed-off-by: ws29.jung --- diff --git a/wrt_app/addon/browser/modules/window.js b/wrt_app/addon/browser/modules/window.js index c7a92f22..44e779da 100644 --- a/wrt_app/addon/browser/modules/window.js +++ b/wrt_app/addon/browser/modules/window.js @@ -10,11 +10,12 @@ module.exports = { showMessageBox: function (winId, options) { let window = TopLevelWindow.fromId(winId); - dialog.showMessageBox(window, options, null); + let showMessageBox = (dialog.showMessageBoxSync || dialog.showMessageBox); + showMessageBox(window, options); }, show: function (winId) { let window = TopLevelWindow.fromId(winId); window.show(); } -} \ No newline at end of file +}