From: hyunuktak Date: Wed, 10 May 2017 08:22:29 +0000 (+0900) Subject: Fixed some svace issues X-Git-Tag: submit/tizen/20170510.102153^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f9e7c35669642f082e3e22dbc8eed035bef1bdfe;p=platform%2Fcore%2Fapi%2Fsmart-traffic-control.git Fixed some svace issues Change-Id: I0fc91a5bee205f2ecd40b6d130a5930e0f883bca Signed-off-by: hyunuktak --- diff --git a/packaging/capi-network-stc.spec b/packaging/capi-network-stc.spec index f55a891..2282831 100755 --- a/packaging/capi-network-stc.spec +++ b/packaging/capi-network-stc.spec @@ -1,6 +1,6 @@ Name: capi-network-stc Summary: A Smart Traffic Control (STC) libraries in Native API -Version: 0.0.1 +Version: 0.0.2 Release: 1 Group: Network & Connectivity/API License: Apache-2.0 diff --git a/src/internal/stc-event.c b/src/internal/stc-event.c index c94739e..419e56e 100755 --- a/src/internal/stc-event.c +++ b/src/internal/stc-event.c @@ -178,8 +178,11 @@ guint _stc_event_add_client_idle_cb(stc_event_info_s *event_data, return 0; data = g_try_new0(stc_event_info_s, 1); - if (!data) + if (!data) { + g_free(idle_data); + idle_data = NULL; return 0; + } memcpy(data, event_data, sizeof(stc_event_info_s)); diff --git a/src/stc-restriction.c b/src/stc-restriction.c index dccc15e..3723ee2 100755 --- a/src/stc-restriction.c +++ b/src/stc-restriction.c @@ -435,28 +435,6 @@ stc_error_e _stc_restriction_validate_rule( "Invalid restriction network interface type [%s]", _stc_convert_iface_type_to_string(restriction_rule->iface_type)); - if (rst_type == STC_RST_TYPE_SET) { - STC_RETURN_VAL_IF(restriction_rule->tx_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid tx limit [%llu]", - restriction_rule->tx_limit); - - STC_RETURN_VAL_IF(restriction_rule->rx_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid rx limit [%llu]", - restriction_rule->rx_limit); - - STC_RETURN_VAL_IF(restriction_rule->tx_warning_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid tx warning limit [%llu]", - restriction_rule->tx_warning_limit); - - STC_RETURN_VAL_IF(restriction_rule->rx_warning_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid rx warning limit [%llu]", - restriction_rule->rx_warning_limit); - } - STC_RETURN_VAL_IF(restriction_rule->roaming_type <= STC_ROAMING_UNKNOWN || restriction_rule->roaming_type > STC_ROAMING_DISABLED, STC_ERROR_INVALID_PARAMETER, @@ -485,26 +463,6 @@ stc_error_e _stc_restriction_check_set_rule( "Invalid restriction network interface type [%s]", _stc_convert_iface_type_to_string(restriction_rule->iface_type)); - STC_RETURN_VAL_IF(restriction_rule->tx_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid tx limit [%llu]", - restriction_rule->tx_limit); - - STC_RETURN_VAL_IF(restriction_rule->rx_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid rx limit [%llu]", - restriction_rule->rx_limit); - - STC_RETURN_VAL_IF(restriction_rule->tx_warning_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid tx warning limit [%llu]", - restriction_rule->tx_warning_limit); - - STC_RETURN_VAL_IF(restriction_rule->rx_warning_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid rx warning limit [%llu]", - restriction_rule->rx_warning_limit); - STC_RETURN_VAL_IF(restriction_rule->roaming_type <= STC_ROAMING_UNKNOWN || restriction_rule->roaming_type > STC_ROAMING_DISABLED, STC_ERROR_INVALID_PARAMETER, @@ -599,26 +557,6 @@ stc_error_e _stc_restriction_check_remove_rule( "Invalid restriction network interface type [%d]", restriction_rule->iface_type); - STC_RETURN_VAL_IF(restriction_rule->tx_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid tx limit [%llu]", - restriction_rule->tx_limit); - - STC_RETURN_VAL_IF(restriction_rule->rx_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid rx limit [%llu]", - restriction_rule->rx_limit); - - STC_RETURN_VAL_IF(restriction_rule->tx_warning_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid tx warning limit [%llu]", - restriction_rule->tx_warning_limit); - - STC_RETURN_VAL_IF(restriction_rule->rx_warning_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid rx warning limit [%llu]", - restriction_rule->rx_warning_limit); - STC_RETURN_VAL_IF(restriction_rule->roaming_type <= STC_ROAMING_UNKNOWN || restriction_rule->roaming_type > STC_ROAMING_DISABLED, STC_ERROR_INVALID_PARAMETER, @@ -651,26 +589,6 @@ stc_error_e _stc_restriction_check_exclude_rule( "Invalid restriction network interface type [%d]", restriction_rule->iface_type); - STC_RETURN_VAL_IF(restriction_rule->tx_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid tx limit [%llu]", - restriction_rule->tx_limit); - - STC_RETURN_VAL_IF(restriction_rule->rx_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid rx limit [%llu]", - restriction_rule->rx_limit); - - STC_RETURN_VAL_IF(restriction_rule->tx_warning_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid tx warning limit [%llu]", - restriction_rule->tx_warning_limit); - - STC_RETURN_VAL_IF(restriction_rule->rx_warning_limit < 0, - STC_ERROR_INVALID_PARAMETER, - "Invalid rx warning limit [%llu]", - restriction_rule->rx_warning_limit); - STC_RETURN_VAL_IF(restriction_rule->roaming_type <= STC_ROAMING_UNKNOWN || restriction_rule->roaming_type > STC_ROAMING_DISABLED, STC_ERROR_INVALID_PARAMETER, diff --git a/test/restriction.c b/test/restriction.c index 205af3c..6c04c16 100755 --- a/test/restriction.c +++ b/test/restriction.c @@ -186,8 +186,7 @@ static int __test_stc_set_restriction_rule(MManager *mm, struct menu_data *menu) return ret; } - if ((rx_limit >= 0 && rx_limit < G_MAXUINT64) && - (tx_limit >= 0 && tx_limit < G_MAXUINT64)) { + if ((rx_limit < G_MAXUINT64) && (tx_limit < G_MAXUINT64)) { ret = stc_restriction_rule_set_limit(g_restriction_rule, rx_limit, tx_limit); if (ret == STC_ERROR_NONE) @@ -199,8 +198,7 @@ static int __test_stc_set_restriction_rule(MManager *mm, struct menu_data *menu) } } - if ((rx_warning_limit >= 0 && rx_warning_limit < G_MAXUINT64) && - (tx_warning_limit >= 0 && tx_warning_limit < G_MAXUINT64)) { + if ((rx_warning_limit < G_MAXUINT64) && (tx_warning_limit < G_MAXUINT64)) { ret = stc_restriction_rule_set_warning_limit(g_restriction_rule, rx_warning_limit, tx_warning_limit); if (ret == STC_ERROR_NONE)