From: Yunhee Seo Date: Mon, 27 Feb 2023 06:30:14 +0000 (+0900) Subject: display: Move set brightness with delay function from plugins to core display module X-Git-Tag: accepted/tizen/unified/20230330.025600~18 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f9ba96c337e2d5bf72f7b44493b6ad4b64dffe8f;p=platform%2Fcore%2Fsystem%2Fdeviced.git display: Move set brightness with delay function from plugins to core display module Move plugin static function to core(display module). This is for moving backlight_ops functions related to brightess without dependency. int display_backlight_set_brightness_with_delay(int brightness, int delay) -> This function replaces the static bl_brt function located in plugins. Change-Id: I4f20da84514cb29e74482980143d09c41354e31b Signed-off-by: Yunhee Seo --- diff --git a/plugins/iot-headed/display/device-interface.c b/plugins/iot-headed/display/device-interface.c index 949ad58..cb0941c 100644 --- a/plugins/iot-headed/display/device-interface.c +++ b/plugins/iot-headed/display/device-interface.c @@ -81,21 +81,6 @@ bool display_dev_ready(void) return display_dev_available; } -static int bl_brt(int brightness, int delay) -{ - int ret = -1; - - if (delay > 0) - usleep(delay); - - /* Update device brightness */ - ret = backlight_ops.set_brightness(brightness); - - _I("Set brightness(%d): %d", brightness, ret); - - return ret; -} - bool display_dimstay_check(void) { if (get_pm_status_flag() & DIM_FLAG) @@ -157,7 +142,7 @@ static void change_brightness(int start, int end, int step) (val < 0 && start < end)) start = end; - bl_brt(start, LCD_PHASED_DELAY); + display_backlight_set_brightness_with_delay(start, LCD_PHASED_DELAY); } } diff --git a/plugins/mobile/display/device-interface.c b/plugins/mobile/display/device-interface.c index e7f64bb..a416a44 100644 --- a/plugins/mobile/display/device-interface.c +++ b/plugins/mobile/display/device-interface.c @@ -80,21 +80,6 @@ bool display_dev_ready(void) return display_dev_available; } -static int bl_brt(int brightness, int delay) -{ - int ret = -1; - - if (delay > 0) - usleep(delay); - - /* Update device brightness */ - ret = backlight_ops.set_brightness(brightness); - - _I("Set brightness(%d): %d", brightness, ret); - - return ret; -} - bool display_dimstay_check(void) { if (get_pm_status_flag() & DIM_FLAG) @@ -156,7 +141,7 @@ static void change_brightness(int start, int end, int step) (val < 0 && start < end)) start = end; - bl_brt(start, LCD_PHASED_DELAY); + display_backlight_set_brightness_with_delay(start, LCD_PHASED_DELAY); } } diff --git a/plugins/tv/display/device-interface.c b/plugins/tv/display/device-interface.c index d16433d..a52a506 100644 --- a/plugins/tv/display/device-interface.c +++ b/plugins/tv/display/device-interface.c @@ -81,21 +81,6 @@ bool display_dev_ready(void) return display_dev_available; } -static int bl_brt(int brightness, int delay) -{ - int ret = -1; - - if (delay > 0) - usleep(delay); - - /* Update device brightness */ - ret = backlight_ops.set_brightness(brightness); - - _I("Set brightness(%d): %d", brightness, ret); - - return ret; -} - bool display_dimstay_check(void) { if (get_pm_status_flag() & DIM_FLAG) @@ -157,7 +142,7 @@ static void change_brightness(int start, int end, int step) (val < 0 && start < end)) start = end; - bl_brt(start, LCD_PHASED_DELAY); + display_backlight_set_brightness_with_delay(start, LCD_PHASED_DELAY); } } diff --git a/plugins/wearable/display/device-interface.c b/plugins/wearable/display/device-interface.c index ca09f35..ed7ee7d 100644 --- a/plugins/wearable/display/device-interface.c +++ b/plugins/wearable/display/device-interface.c @@ -93,21 +93,6 @@ bool display_dev_ready(void) return display_dev_available; } -static int bl_brt(int brightness, int delay) -{ - int ret = -1; - - if (delay > 0) - usleep(delay); - - /* Update device brightness */ - ret = backlight_ops.set_brightness(brightness); - - _I("Set brightness(%d): %d", brightness, ret); - - return ret; -} - bool display_dimstay_check(void) { if (get_pm_status_flag() & DIM_FLAG) @@ -166,7 +151,7 @@ static void change_brightness(int start, int end, int step) (val < 0 && start < end)) start = end; - bl_brt(start, LCD_PHASED_DELAY); + display_backlight_set_brightness_with_delay(start, LCD_PHASED_DELAY); } } diff --git a/src/display/display-backlight.c b/src/display/display-backlight.c index a8215bc..0f3e8ea 100644 --- a/src/display/display-backlight.c +++ b/src/display/display-backlight.c @@ -274,6 +274,20 @@ void display_backlight_unset_blink(void) release_timer = g_timeout_add(DUMP_MODE_WAITING_TIME, release_blink_cb, NULL); } +int display_backlight_set_brightness_with_delay(int brightness, int delay) +{ + int ret = -1; + + if (delay > 0) + usleep(delay); + + /* Update device brightness */ + ret = backlight_ops->set_brightness(brightness); + _I("Set brightness(%d): %d", brightness, ret); + + return ret; +} + /* FIXME: This function is only used for wearable plugin */ int display_backlight_set_force_brightness(int brightness) { diff --git a/src/display/display-backlight.h b/src/display/display-backlight.h index 54fc5d1..7c1349d 100644 --- a/src/display/display-backlight.h +++ b/src/display/display-backlight.h @@ -36,5 +36,6 @@ void display_backlight_set_blink(int timeout); void display_backlight_unset_blink(void); int display_backlight_set_force_brightness(int brightness); void display_backlight_get_force_brightness(int *brightness); +int display_backlight_set_brightness_with_delay(int brightness, int delay); #endif /* __DISPLAY_BACKLIGHT_H__ */ \ No newline at end of file