From: Oliver Neukum Date: Thu, 17 Feb 2022 13:35:49 +0000 (+0100) Subject: xhci: omit mem read just after allocation of trb X-Git-Tag: v6.1-rc5~1706^2~81 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f9aeda81c0e8cfd6c5b21401f6206b2c7584f876;p=platform%2Fkernel%2Flinux-starfive.git xhci: omit mem read just after allocation of trb This has been allocated just a few lines earlier with a zalloc(). The value is known and "|=" is a waste of memory cycles. Acked-by: Mathias Nyman Signed-off-by: Oliver Neukum Link: https://lore.kernel.org/r/20220217133549.27961-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index f8c2b6c..cb70d0b 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -57,7 +57,7 @@ static struct xhci_segment *xhci_segment_alloc(struct xhci_hcd *xhci, /* If the cycle state is 0, set the cycle bit to 1 for all the TRBs */ if (cycle_state == 0) { for (i = 0; i < TRBS_PER_SEGMENT; i++) - seg->trbs[i].link.control |= cpu_to_le32(TRB_CYCLE); + seg->trbs[i].link.control = cpu_to_le32(TRB_CYCLE); } seg->dma = dma; seg->next = NULL;