From: Ville Syrjälä Date: Tue, 13 Nov 2018 17:23:29 +0000 (+0200) Subject: drm/i915: Remove bogus FIXME from SKL wm computation X-Git-Tag: v5.4-rc1~1388^2~28^2~90 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f9a954ff02dfa6c7b3cf76281ee47d7373269b1d;p=platform%2Fkernel%2Flinux-rpi.git drm/i915: Remove bogus FIXME from SKL wm computation We do return an error when the watermark calculation fails, so the FIXME claiming otherwise is outdated. Remove it. Cc: Stanislav Lisovskiy Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20181113172330.26069-2-ville.syrjala@linux.intel.com Reviewed-by: Rodrigo Vivi --- diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index eadcece..8ed88b4 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -5549,10 +5549,6 @@ skl_compute_wm(struct drm_atomic_state *state) * Note that the DDB allocation above may have added more CRTC's that * weren't otherwise being modified (and set bits in dirty_pipes) if * pipe allocations had to change. - * - * FIXME: Now that we're doing this in the atomic check phase, we - * should allow skl_update_pipe_wm() to return failure in cases where - * no suitable watermark values can be found. */ for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, cstate, i) { struct intel_crtc_state *intel_cstate =